Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink for BaseTsd.h in SDK headers. #41

Merged
merged 2 commits into from
May 4, 2022

Conversation

jemc
Copy link
Contributor

@jemc jemc commented May 3, 2022

The capitalized version of this header is shown in Microsoft docs,
and it is used in places like the Pony runtime:
https://github.com/ponylang/ponyc/blob/8d41d6650b48b9733cd675df199588e6fccc6346/src/common/platform.h#L191

This commit adds a symlink for this file, in the same place in
the codebase where an special case already existed for another
header that is used by the libzmq project.

@jemc jemc requested a review from Jake-Shadle as a code owner May 3, 2022 22:01
jemc and others added 2 commits May 4, 2022 07:46
The capitalized version of this header is shown in Microsoft docs,
and it is used in places like the Pony runtime:
https://github.com/ponylang/ponyc/blob/8d41d6650b48b9733cd675df199588e6fccc6346/src/common/platform.h#L191

This commit adds a symlink for this file, in the same place in
the codebase where an special case already existed for another
header that is used by the `libzmq` project.
Copy link
Owner

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle Jake-Shadle merged commit 61a1a1e into Jake-Shadle:main May 4, 2022
@jemc jemc deleted the add/symlink-basetsd-h branch May 4, 2022 22:08
@jemc
Copy link
Contributor Author

jemc commented May 4, 2022

Thanks for the quick merge, and thanks for this great tool!

Because of xwin, I'm now able to build the Pony/Savi language runtime in CI on a Linux host

@Jake-Shadle
Copy link
Owner

Nice, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants