Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When initializing a response it should throw if status is not in the range 200 to 599 #1213

Closed
tkrotoff opened this issue Dec 1, 2022 · 0 comments · Fixed by #1356
Closed

Comments

@tkrotoff
Copy link
Contributor

tkrotoff commented Dec 1, 2022

From the spec https://fetch.spec.whatwg.org/#response-class

To initialize a response, given a Response object response, ResponseInit init, and an optional body with type body, run these steps:
 1. If init["status"] is not in the range 200 to 599, inclusive, then throw a RangeError.
 2. If init["statusText"] does not match the reason-phrase token production, then throw a TypeError.
 [...]
 6. If body was given, then:
      1. If response’s status is a null body status, then throw a TypeError.
      [...]

Reproduction

new Response('body', { status: 204 }); // KO Not throwing
new Response(undefined, { status: 204 }); // Not throwing is correct here
new Response(undefined, { status: 0 }); // KO Not throwing

Expected behavior

Under Chrome 107:

new Response('body', { status: 204 });
// TypeError: Failed to construct 'Response': Response with null body status cannot have body

new Response(undefined, { status: 204 });
// No throwing

new Response(undefined, { status: 0 });
// RangeError: Failed to construct 'Response': The status provided (0) is outside the range [200, 599].

Your Environment

software version
whatwg-fetch 3.6.2
node 18.12.1
npm 8.19.2
Operating System macOS Monterey

Related issue: node-fetch/node-fetch#1685

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@tkrotoff and others