always set a signal on Request

[romainmenke]

https://fetch.spec.whatwg.org/#request-class

new Request(input, init) constructor step : 28

Set this’s signal to a new AbortSignal object with this’s relevant Realm.

latest Chrome :

new Request('').signal
// AbortSignal {aborted: false, onabort: null}

Also checked Safari/Firefox and this is implemented in all of them.

---

I wasn't sure how to run the test suite.
I had een error that seemed unrelated to the actual feature tests :

25 07 2021 09:11:12.524:INFO [framework.detect-browsers]: The following browsers will be used: [ 'ChromeHeadlessNoSandbox',
  'ChromeCanaryHeadlessNoSandbox',
  'FirefoxHeadless',
  'Safari',
  'SafariTechPreview' ]
25 07 2021 09:11:12.605:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9877/
25 07 2021 09:11:12.605:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox, ChromeCanaryHeadlessNoSandbox, FirefoxHeadless, Safari, SafariTechPreview with concurrency unlimited
25 07 2021 09:11:12.610:ERROR [launcher]: Cannot load browser "ChromeCanaryHeadlessNoSandbox": it is not registered! Perhaps you are missing some plugin?
25 07 2021 09:11:12.611:ERROR [karma-server]: Error: Found 1 load error
    at Server.webServer.listen (./fetch/node_modules/karma/lib/server.js:182:27)
    at Object.onceWrapper (events.js:286:20)
    at Server.emit (events.js:203:15)
    at emitListeningNT (net.js:1314:10)
    at process._tickCallback (internal/process/next_tick.js:63:19)
25 07 2021 09:11:12.612:INFO [launcher]: Starting browser ChromeHeadless
25 07 2021 09:11:12.619:INFO [launcher]: Starting browser FirefoxHeadless
25 07 2021 09:11:12.636:INFO [launcher]: Starting browser Safari
25 07 2021 09:11:12.640:INFO [launcher]: Starting browser SafariTechPreview

[JakeChampion]

Thanks for this @romainmenke

[JakeChampion]

Regarding:

I wasn't sure how to run the test suite.
I had een error that seemed unrelated to the actual feature tests :

25 07 2021 09:11:12.524:INFO [framework.detect-browsers]: The following browsers will be used: [ 'ChromeHeadlessNoSandbox',
  'ChromeCanaryHeadlessNoSandbox',
  'FirefoxHeadless',
  'Safari',
  'SafariTechPreview' ]
25 07 2021 09:11:12.605:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9877/
25 07 2021 09:11:12.605:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox, ChromeCanaryHeadlessNoSandbox, FirefoxHeadless, Safari, SafariTechPreview with concurrency unlimited
25 07 2021 09:11:12.610:ERROR [launcher]: Cannot load browser "ChromeCanaryHeadlessNoSandbox": it is not registered! Perhaps you are missing some plugin?
25 07 2021 09:11:12.611:ERROR [karma-server]: Error: Found 1 load error
    at Server.webServer.listen (./fetch/node_modules/karma/lib/server.js:182:27)
    at Object.onceWrapper (events.js:286:20)
    at Server.emit (events.js:203:15)
    at emitListeningNT (net.js:1314:10)
    at process._tickCallback (internal/process/next_tick.js:63:19)
25 07 2021 09:11:12.612:INFO [launcher]: Starting browser ChromeHeadless
25 07 2021 09:11:12.619:INFO [launcher]: Starting browser FirefoxHeadless
25 07 2021 09:11:12.636:INFO [launcher]: Starting browser Safari
25 07 2021 09:11:12.640:INFO [launcher]: Starting browser SafariTechPreview

Could you let me know which version of NodeJS and npm you were using when this happened?

[romainmenke]

I tried a range of different node versions (10, 12, 16) and get the error in each.
My best guess is that it is my local setup and maybe not an issue in this repo.