Centralise the checks for blob and form data support #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,9 +110,9 @@ | |||
| this._bodyInit = body | |||
| if (typeof body === 'string') { | |||
| this._bodyText = body | |||
| } else if ('Blob' in self && Blob.prototype.isPrototypeOf(body)) { | |||
| } else if (blobSupport && Blob.prototype.isPrototypeOf(body)) { | |||
There was a problem hiding this comment.
wasn't sure about this because blobSupport actually checks a lot more than just 'Blob' in self
|
If it would help you more, I wouldn't mind centralizing all the checks to the top with a single object like var support = {
"Blob": howeverTestBlob,
"FileReader": somethingTestFileReader
}We could even export it as |
|
Umm, I don't mind. I would just like it to do its checks upfront so that I can restore I can definitely tidy them all up into a single object though. |
|
❤️ |
josh
added a commit
that referenced
this pull request
Jan 24, 2015
Centralise the checks for blob and form data support
|
Would you mind if I made a (minor) release for this & #77? |
|
no problem, done 115cd97 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with isomorphic-fetch (currently it's relying on a fork that has these extra few lines:- https://github.com/matthew-andrews/fetch/blob/master/fetch.js#L3-5) and (I think) makes fetch's implementation simpler.