Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in the limited support IE9 offers for cross-origin requests #79

Closed
wants to merge 16 commits into from

Conversation

matthew-andrews
Copy link
Contributor

No description provided.

@josh
Copy link
Contributor

josh commented Jan 24, 2015

Oh, fun :trollface:

Thanks for getting this going. I'll probably need to take some time to test this all locally myself. A little busy next week.

I think we'll probably want to get CORS tests going at this point.

@matthew-andrews
Copy link
Contributor Author

This one is going to be especially fun to write tests for — SauceLabs?

Also I don't know JavaScript as well as you to know when not to use ;s 😞.

No rush for this and yes CORS testing…

@domenic
Copy link

domenic commented Jan 24, 2015

Don't do it. XDomainRequest is so far from XHR semantics you're going to be chasing bugs for years...

@josh
Copy link
Contributor

josh commented Jan 24, 2015

This one is going to be especially fun to write tests for — SauceLabs?

Yeah, I really need to get that working too. CI is just using PhantomJS right now.

I'll probably steal the SauceLabs scripts I wrote for another project.

https://github.com/josh/async-form-element/blob/master/.travis.yml#L8-L13
https://github.com/josh/async-form-element/blob/master/test/saucelabs.js

Also I don't know JavaScript as well as you to know when not to use ;s

I'm actually in the pro semicolon camp 😏, but I didn't start this project.

Don't do it. XDomainRequest is so far from XHR semantics you're going to be chasing bugs for years...

Haha. I personally don't need so I don't care too much about IE9 CORS support.

@matthew-andrews
Copy link
Contributor Author

Haha. I personally don't need so I don't care too much about IE9 CORS support.

Sadly, we do 😞.

@josh
Copy link
Contributor

josh commented Jan 24, 2015

Sadly, we do 😞.

Sorry, I didn't mean we couldn't investigate it. Especially if you'll be helping on the implementation.

@dgraham
Copy link
Contributor

dgraham commented Jan 25, 2015

The ideal place for this investigation to happen is a fork that matures on a production site. The maintenance burden of supporting non-standard APIs is too great for this mainline polyfill. Think of this repo as jQuery 2.x, supporting recent browsers, and the fork as jQuery 1.x, providing compatibility to old browsers.

We need to avoid exposing github.com traffic to this, where we have no way of properly testing it, because we don't make cross-origin requests from IE 9. Unless @josh has time to test and maintain this in the future, I think we should close this out.

@josh
Copy link
Contributor

josh commented Jan 25, 2015

The ideal place for this investigation to happen is a fork that matures on a production site.

@matthew-andrews is working on this for production @ftlabs apps.

@matthew-andrews
Copy link
Contributor Author

Yup. This'll go on the new responsive version of FT.com that we're working on right now. You'll be glad to hear that IE9 is as far back as we have to go (which the fetch polyfill does claim support of so I would argue that it's not quite the same as jQuery 1 vs. 2) but if you'd prefer not to merge it that's cool—we can use my fork.

I might make a PR to update this repo's README.md to warn about partial IE9 support, would that be OK?

@josh
Copy link
Contributor

josh commented Jan 26, 2015

I think if we can get a CORS suite done first (which we'll want no matter what), then see how complicated it would be to make it work in IE 9 and decide if its worth it. Maybe its super gnarly 100 lines or maybe its not too bad. I'm pretty sure @matthew-andrews is in to help maintain it if it makes it in core.

Does that sound like a good plan?

@josh josh mentioned this pull request Mar 16, 2015
@dgraham
Copy link
Contributor

dgraham commented Jul 18, 2015

Closing per #176 (comment):

. . . we ended up giving up on trying to make XDomainRequest work (it just wasn't good enough for us for any but the most basic cases)

@dgraham dgraham closed this Jul 18, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants