Skip to content
This repository has been archived by the owner on Aug 4, 2024. It is now read-only.

TypedArray polyfills are included for every browser target #667

Closed
connorjclark opened this issue Jun 11, 2020 · 0 comments · Fixed by #945
Closed

TypedArray polyfills are included for every browser target #667

connorjclark opened this issue Jun 11, 2020 · 0 comments · Fixed by #945
Labels
library Relates to an Origami library

Comments

@connorjclark
Copy link

TypeArray marks all browsers as *: https://github.com/Financial-Times/polyfill-library/blob/master/polyfills/_TypedArray/config.toml#L19

These polyfills were added in #1374.

In efab9f1#diff-0ad6891d5cf8b4686627e337d7ce5f4c it was all changed to *. Note that this is the only file in this commit that version information was lost. Might it have been by mistake?
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Jun 11, 2020
@connorjclark connorjclark mentioned this issue Jun 11, 2020
Open
JakeChampion added a commit that referenced this issue Dec 16, 2020
@JakeChampion
Update targeting for TypedArray polyfills
ad5d38b 
The numbers were taken from MDN -- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray#Browser_compatibility

Fixes #667
@JakeChampion JakeChampion mentioned this issue Dec 16, 2020
Merged
Origami ✨ automation moved this from incoming to complete Dec 18, 2020
@github-actions github-actions bot added the library Relates to an Origami library label Dec 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
library Relates to an Origami library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update targeting for TypedArray polyfills JakeChampion/polyfill-library
1 participant
@connorjclark