Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds polyfills for TypedArray.prototype methods #1208

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Adds polyfills for TypedArray.prototype methods #1208

merged 1 commit into from
Aug 4, 2022

Conversation

mhassan1
Copy link
Collaborator

@mhassan1 mhassan1 commented Aug 2, 2022

This PR adds the following polyfills:

  • TypedArray.prototype.@@iterator
  • TypedArray.prototype.entries
  • TypedArray.prototype.keys
  • TypedArray.prototype.toLocaleString
  • TypedArray.prototype.toString
  • TypedArray.prototype.values

These are all noted as missing in the ArrayBuffer polyfill (i.e. link, link, link).

@mhassan1 mhassan1 requested a review from a team as a code owner August 2, 2022 18:29
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Aug 2, 2022
@github-actions github-actions bot added the library Relates to an Origami library label Aug 2, 2022
Copy link
Collaborator

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some config tweaks

polyfills/TypedArray/prototype/@@iterator/config.toml Outdated Show resolved Hide resolved
polyfills/TypedArray/prototype/entries/config.toml Outdated Show resolved Hide resolved
polyfills/TypedArray/prototype/toLocaleString/config.toml Outdated Show resolved Hide resolved
polyfills/TypedArray/prototype/toString/config.toml Outdated Show resolved Hide resolved
`TypedArray.prototype.@@iterator`
`TypedArray.prototype.entries`
`TypedArray.prototype.keys`
`TypedArray.prototype.toLocaleString`
`TypedArray.prototype.toString`
`TypedArray.prototype.values`
@romainmenke
Copy link
Collaborator

Copy link
Collaborator

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @mhassan1 🎉
Awesome work as always.

@romainmenke romainmenke merged commit e84b08d into JakeChampion:master Aug 4, 2022
Origami ✨ automation moved this from Backlog to Done Aug 4, 2022
@mhassan1 mhassan1 deleted the typedarray-prototype-methods branch June 30, 2023 12:41
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants