-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate browser configs (part 2) #1220
Merged
romainmenke
merged 11 commits into
master
from
validate-browser-configs--considerate-cuttlefish-5f534b11a6
Aug 9, 2022
Merged
validate browser configs (part 2) #1220
romainmenke
merged 11 commits into
master
from
validate-browser-configs--considerate-cuttlefish-5f534b11a6
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fill in blanks for op_mob and firefox_mob - validate ios_saf versions
…nfigs--considerate-cuttlefish-5f534b11a6
…nfigs--considerate-cuttlefish-5f534b11a6
romainmenke
commented
Aug 6, 2022
romainmenke
commented
Aug 6, 2022
…nfigs--considerate-cuttlefish-5f534b11a6
JakeChampion
approved these changes
Aug 9, 2022
romainmenke
deleted the
validate-browser-configs--considerate-cuttlefish-5f534b11a6
branch
August 9, 2022 17:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_mob
andfirefox_mob
ios_saf
versionsmajor.minor
as the significant version forsamsung_mob
(same assafari
)safari
in the past few monthsmore improvements to the lint config script with the final results looking like this :