Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate browser configs (part 2) #1220

Merged

Conversation

romainmenke
Copy link
Collaborator

@romainmenke romainmenke commented Aug 5, 2022

  • fill in blanks for op_mob and firefox_mob
  • validate ios_saf versions
  • use major.minor as the significant version for samsung_mob (same as safari)
  • a few configs looked suspicious and have been fixed
  • a few features shipped in safari in the past few months

more improvements to the lint config script with the final results looking like this :

### Browsers
- 83 missing
- 2 unknown
- 19 unbounded ('*' or '>5')

### Meta
- 27 missing docs link

### Log
- 4 warnings
- 2 info messages

- fill in blanks for op_mob and firefox_mob
- validate ios_saf versions
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Aug 5, 2022
@github-actions github-actions bot added the library Relates to an Origami library label Aug 5, 2022
@romainmenke romainmenke marked this pull request as ready for review August 6, 2022 16:27
@romainmenke romainmenke requested a review from a team as a code owner August 6, 2022 16:27
@romainmenke romainmenke merged commit 03bac75 into master Aug 9, 2022
Origami ✨ automation moved this from Backlog to Done Aug 9, 2022
@romainmenke romainmenke deleted the validate-browser-configs--considerate-cuttlefish-5f534b11a6 branch August 9, 2022 17:27
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants