Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CharacterData.prototype polyfills #1224

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Adds CharacterData.prototype polyfills #1224

merged 1 commit into from
Aug 13, 2022

Conversation

mhassan1
Copy link
Collaborator

This PR adds polyfills for CharacterData.prototype:

  • after
  • before
  • nextElementSibling
  • previousElementSibling
  • remove
  • replaceWith

This list includes all properties of CharacterData.prototype that may be missing from the browsers we target, based on https://developer.mozilla.org/en-US/docs/Web/API/CharacterData#browser_compatibility.

Resolves #214.

CharacterData.prototype.after
CharacterData.prototype.before
CharacterData.prototype.nextElementSibling
CharacterData.prototype.previousElementSibling
CharacterData.prototype.remove
CharacterData.prototype.replaceWith
@mhassan1 mhassan1 requested a review from a team as a code owner August 11, 2022 02:05
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Aug 11, 2022
@github-actions github-actions bot added the library Relates to an Origami library label Aug 11, 2022
@romainmenke
Copy link
Collaborator

romainmenke commented Aug 11, 2022

/ok-to-test sha=4aa39a1

https://github.com/Financial-Times/polyfill-library/actions/runs/2837762185

@romainmenke
Copy link
Collaborator

Thank you @mhassan1 🙇

@romainmenke romainmenke merged commit fee329a into JakeChampion:master Aug 13, 2022
Origami ✨ automation moved this from Backlog to Done Aug 13, 2022
@mhassan1 mhassan1 deleted the characterdata-prototype branch June 30, 2023 12:40
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Relates to an Origami library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: nextElementSibling, previousElementSibling on CharacterData
3 participants