Streamline TypedArray polyfills #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lehni
force-pushed
the
refactor/streamline-typedarray-polyfills
branch
from
2b8cca4
to
970dac3
Compare
|
/ok-to-test sha=970dac3 Tests running at https://github.com/Financial-Times/polyfill-library/actions/runs/4876969635 |
JakeChampion
approved these changes
May 3, 2023
|
@lehni thanks for the PR, it all looks good but we can't merge it as it is now out-of-date with the base branch abd I don't have the permission to write to your fork. Would you be able to either give me permission on the fork or rebase your work so that I can merge it in? |
- Use fnName variable instead of repeated identical strings, for better minification - Remove unnecessary createMethodProperties(fn) function, in favour of same structure in all different polyfills
lehni
force-pushed
the
refactor/streamline-typedarray-polyfills
branch
from
970dac3
to
0f4eee7
Compare
|
@JakeChampion I've just rebased it. I hope this works! |
|
/ok-to-test sha=0f4eee7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fnNamevariable instead of repeated identical strings, for better minificationcreateMethodProperties(fn)function, in favour of same structure in all different polyfills