Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #55

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Update package.json #55

merged 3 commits into from
Oct 5, 2018

Conversation

shmick
Copy link
Contributor

@shmick shmick commented Oct 5, 2018

No description provided.

@JakePartusch
Copy link
Owner

Hey @shmick! Thanks for the help! If you have a chance would you be able to look into upgrading the other dependencies (React, React-Router, etc)? I'll look into the Cypress tests to see if the upgrade broke the CI build.

@JakePartusch
Copy link
Owner

JakePartusch commented Oct 5, 2018

Looks like the new version of react-scripts is asking for supported browsers.

We're unable to detect target browsers.

Would you be able to add the default selection? It should populate if you run the application locally with yarn start

@shmick
Copy link
Contributor Author

shmick commented Oct 5, 2018

Looks like the new version of react-scripts is asking for supported browsers.

We're unable to detect target browsers.

Would you be able to add the default selection? It should populate if you run the application locally with yarn start

Done. Looks better now.

@JakePartusch
Copy link
Owner

Awesome @shmick 🙌 Thanks!

@JakePartusch JakePartusch merged commit d8c9b46 into JakePartusch:master Oct 5, 2018
@shmick shmick deleted the Issue50-LibraryUpdates branch October 5, 2018 03:22
@JakePartusch JakePartusch mentioned this pull request Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants