Skip to content

Commit

Permalink
fix: adding support for relative urls in the sitemap. (#9)
Browse files Browse the repository at this point in the history
Better error handling for individual page exceptions
  • Loading branch information
JakePartusch committed Feb 27, 2020
1 parent b70952b commit 0cad029
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 27 deletions.
67 changes: 40 additions & 27 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,39 +12,50 @@ const fetchSitemapUrls = async baseUrl => {
if (maxSites === 0) {
return [baseUrl];
}
return sites.slice(0, maxSites);
const absoluteUrlSites = sites.map(site => {
if (site.startsWith("/")) {
return `${baseUrl}${site}`;
}
return site;
});
return absoluteUrlSites.slice(0, maxSites);
};

const runAccessibilityTestsOnUrl = async url => {
const browser = await chromium.launch();
const context = await browser.newContext();
const page = await context.newPage();
await page.goto(url);
await page.addScriptTag({
url: "https://cdnjs.cloudflare.com/ajax/libs/axe-core/3.4.2/axe.min.js"
});
const axeViolations = await page.evaluate(async () => {
const axeResults = await new Promise((resolve, reject) => {
window.axe.run((err, results) => {
if (err) {
reject(err);
} else {
resolve(results);
}
});
try {
const page = await context.newPage();
await page.goto(url);
await page.addScriptTag({
url: "https://cdnjs.cloudflare.com/ajax/libs/axe-core/3.4.2/axe.min.js"
});
const axeViolations = await page.evaluate(async () => {
const axeResults = await new Promise((resolve, reject) => {
window.axe.run((err, results) => {
if (err) {
reject(err);
} else {
resolve(results);
}
});
});

return {
violations: axeResults.violations.map(violation => ({
id: violation.id,
impact: violation.impact,
description: violation.description,
nodes: violation.nodes.map(node => node.html)
}))
};
});
await browser.close();
return { url, ...axeViolations };
return {
violations: axeResults.violations.map(violation => ({
id: violation.id,
impact: violation.impact,
description: violation.description,
nodes: violation.nodes.map(node => node.html)
}))
};
});
return { url, ...axeViolations };
} catch (e) {
return { url, violations: [], error: e.message };
} finally {
await browser.close();
}
};

const runAllChecks = async (urls, spinner) => {
Expand All @@ -55,7 +66,9 @@ const runAllChecks = async (urls, spinner) => {
spinner.text = `Running accessibility checks... (${totalViolationsByPage.length ||
1} of ${urls.length} pages)`;
}
const violationPromises = urlChunk.map(url => runAccessibilityTestsOnUrl(url));
const violationPromises = urlChunk.map(url =>
runAccessibilityTestsOnUrl(url)
);
const resolvedViolationsByPage = await Promise.all(violationPromises);
totalViolationsByPage.push(...resolvedViolationsByPage);
}
Expand Down
4 changes: 4 additions & 0 deletions src/output.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ const sortViolationsBySeverity = violations => {

const printResults = toalViolationsByPage => {
for (const violationByPage of toalViolationsByPage) {
if (violationByPage.error) {
logUrl(violationByPage.url);
console.log(chalk`{red ERROR: ${violationByPage.error}}`);
}
if (violationByPage.violations.length > 0) {
logUrl(violationByPage.url);
const sortedViolations = sortViolationsBySeverity(
Expand Down

0 comments on commit 0cad029

Please sign in to comment.