Optimize read lid state function #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| LidState::Unknown | ||
| }; | ||
| Ok(state) | ||
| Ok(match lid_str.split_whitespace().last().unwrap() { |
There was a problem hiding this comment.
Would the unwrap crash acs if the lid file wasn't in the right file or doesn't exist?
There was a problem hiding this comment.
It might be a safe assumption that it's in the correct format
There was a problem hiding this comment.
wait actually, could you do unwrap or error and set state = LidState::Unknown if it doesn't unwrap correctly otherwise return the state
There was a problem hiding this comment.
It does not crash. The if statement before prevents the crash.
if !self.found_path {
return Ok(LidState::Unapplicable);
}
|
Perfect PR. Works, Fixes issue, stays in scope, best solution. A+ work |
|
Tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced two contains checks into a single split_whitespace() call with a match statement. Fixes #465