Create class warning (fix) #80
Conversation
|
The changes look fine. I don't think this pull request needs some changes in gitignore, but it's not an issue. Tested building and examples locally. Also the result is fine without react 15.5.0 warning. |
|
@romamatusevich since adding coverage to the v3 alpha, I figured it was easier for me to update the gitignore in v2 than to keep deleting all the output files. Shouldn't have any impact on the lib itself. :) |
|
If you're happy I'll merge and release it now. |
|
Thank you! |
|
Why not simply convert it to a ES6 class instead of using that create-class library? Is there some blocking dependency? |
|
ES6 classes work pretty differently, e.g. not binding methods. This was the quickest way to get a fix out. Otherwise I'd not only have to re-write the component, but setup all the build / dist stuff to work with ES6. Will likely be rewriting in TypeScript in the near future. |
|
Aha makes sense 👍 |
Fixes #79