This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Performance improvement in DiskLruCache.readJournalLine(). #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original AOSP/libcore change by Vladimir Marko: Speed up DiskLruCache.readJournalLine() by avoiding memory allocations from String.split(). For non-CLEAN lines, we avoid using String.split() altogether and find separators explicitly, for CLEAN lines we defer to String.split() and we optimize the underlying Splitter.fastSplit() overload to avoid unnecessary allocations itself. On a test journal with 7347 entries (1099 CLEAN) this saves about 45-50% from ~250ms. On a test journal with 272 entries (86 CLEAN) this saves about 35-40% from ~10ms. Measured loadJournal on GN in a tight loop (file contents cached). If used without the other DiskLruCache.readJournalLine() improvements, the Splitter.fastSplit() optimization alone would provide about 60% of the savings. It should also speed up other code outside the DiskLruCache. Change-Id: I1d6c6b13d54d8fcba3081f2bb9df701b58f5e143
JakeWharton
added a commit
that referenced
this pull request
Dec 24, 2012
Performance improvement in DiskLruCache.readJournalLine().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original AOSP/libcore change by Vladimir Marko:
Speed up DiskLruCache.readJournalLine() by avoiding memory
allocations from String.split(). For non-CLEAN lines, we
avoid using String.split() altogether and find separators
explicitly, for CLEAN lines we defer to String.split() and
we optimize the underlying Splitter.fastSplit() overload to
avoid unnecessary allocations itself.
On a test journal with 7347 entries (1099 CLEAN) this saves
about 45-50% from ~250ms. On a test journal with 272 entries
(86 CLEAN) this saves about 35-40% from ~10ms. Measured
loadJournal on GN in a tight loop (file contents cached).
If used without the other DiskLruCache.readJournalLine()
improvements, the Splitter.fastSplit() optimization alone
would provide about 60% of the savings. It should also
speed up other code outside the DiskLruCache.
Change-Id: I1d6c6b13d54d8fcba3081f2bb9df701b58f5e143