Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Increase key length limit to 120. #65

Closed
wants to merge 3 commits into from

Conversation

acherkashyn
Copy link

Increase the key length limit and update unit tests accordingly.

@JakeWharton
Copy link
Owner

I'm wondering if enforcing a length is useful at all. @swankjesse?

@swankjesse
Copy link
Collaborator

If we were ever to switch to a binary encoding, we'd want a length limit like 255 so we can store the length in a single byte. And because the key name is used as a filename we shouldn't let it go arbitrarily long.

But 120 should be fine.

@gubatron
Copy link
Contributor

really cool observation @swankjesse (in that case just raise it now to 255 then)

@JakeWharton
Copy link
Owner

The file name limit is 127 on Android. 120 is good.
On Jul 22, 2014 6:49 PM, "Angel Leon" notifications@github.com wrote:

really cool observation @swankjesse https://github.com/swankjesse (in
that case just raise it now to 255 then)


Reply to this email directly or view it on GitHub
#65 (comment)
.

@acherkashyn
Copy link
Author

So then... merge? :)

@JakeWharton
Copy link
Owner

Squashed and merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants