Add SwipeDismissBehavior event binding #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new AssertionError("The view is not in a Coordinator Layout."); | ||
| } | ||
| final SwipeDismissBehavior behavior = | ||
| (SwipeDismissBehavior) ((CoordinatorLayout.LayoutParams) view.getLayoutParams()).getBehavior(); |
There was a problem hiding this comment.
This should do an instanceof as well and throw a nice message.
xfumihiro
force-pushed
the
feature/swipedismissbehavior
branch
from
fe1edf8
to
2b39ae5
Compare
| return Observable.create(new SwipeDismissBehaviorOnSubscribe(view)); | ||
| } | ||
|
|
||
| private RxSwipeDismissBehavior() { throw new AssertionError("No instances."); } |
There was a problem hiding this comment.
Not a huge fan of shoving this on to one line because everything else uses multiple lines.
xfumihiro
force-pushed
the
feature/swipedismissbehavior
branch
from
2b39ae5
to
b3b2935
Compare
xfumihiro
force-pushed
the
feature/swipedismissbehavior
branch
from
b3b2935
to
fd3e7cd
Compare
JakeWharton
added a commit
that referenced
this pull request
Oct 7, 2015
Add SwipeDismissBehavior event binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #57.