Change Observable<Any> to <Unit> in kotlin api #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Jan 4, 2017
| @@ -31,4 +31,4 @@ inline fun CompoundButton.checked(): Consumer<in Boolean> = RxCompoundButton.che | |||
| * *Warning:* The created observable keeps a strong reference to `view`. Unsubscribe | |||
| * to free this reference. | |||
| */ | |||
| inline fun CompoundButton.toggle(): Consumer<in Any> = RxCompoundButton.toggle(this) | |||
| inline fun CompoundButton.toggle(): Consumer<in Unit> = RxCompoundButton.toggle(this) | |||
There was a problem hiding this comment.
This one is incorrect. We need to limit it to Observable only.
|
Oh. I looked through but I missed that.
I'll try to fix it tomorrow.
…On Wed, Jan 4, 2017, 16:05 Jake Wharton ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
rxbinding-kotlin/src/main/kotlin/com/jakewharton/rxbinding2/widget/RxCompoundButton.kt
<#345 (review)>
:
> @@ -31,4 +31,4 @@ inline fun CompoundButton.checked(): Consumer<in Boolean> = RxCompoundButton.che
* *Warning:* The created observable keeps a strong reference to `view`. Unsubscribe
* to free this reference.
*/
-inline fun CompoundButton.toggle(): Consumer<in Any> = RxCompoundButton.toggle(this)
+inline fun CompoundButton.toggle(): Consumer<in Unit> = RxCompoundButton.toggle(this)
This one is incorrect. We need to limit it to Observable only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#345 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEsNzs6oW6pZxckSix4b4Z1B-ZuzBS84ks5rO7U-gaJpZM4Lamdj>
.
|
|
Fixed in: #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you mention here: #335 (comment)
I've changed the way
KotlinGetTaskhandleObjecttype.I've also regenerate kotlin.