Update error-prone and fix missing fail warnings

JakeWharton · Sep 13, 2019 · faef275 · faef275
1 parent 80174ec
commit faef275
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -73,12 +73,16 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.3</version>
+        <version>3.5</version>
         <configuration>
           <compilerId>javac-with-errorprone</compilerId>
           <forceJavacCompilerUse>true</forceJavacCompilerUse>
           <source>${java.version}</source>
           <target>${java.version}</target>
+          <showWarnings>true</showWarnings>
+          <compilerArgs>
+            <arg>-Xep:MissingFail:ERROR</arg>
+          </compilerArgs>
         </configuration>
         <dependencies>
           <dependency>
@@ -89,7 +93,7 @@
           <dependency>
             <groupId>com.google.errorprone</groupId>
             <artifactId>error_prone_core</artifactId>
-            <version>2.0.15</version>
+            <version>2.3.3</version>
           </dependency>
         </dependencies>
       </plugin>

diff --git a/replaying-share/src/test/java/com/jakewharton/rx/ReplayingShareFlowableTest.java b/replaying-share/src/test/java/com/jakewharton/rx/ReplayingShareFlowableTest.java
@@ -29,6 +29,7 @@
 import org.reactivestreams.Subscription;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
 
 public final class ReplayingShareFlowableTest {
   @Test public void noInitialValue() {
@@ -105,6 +106,7 @@ public final class ReplayingShareFlowableTest {
     };
     try {
       flowable.subscribe(brokenAction);
+      fail();
     } catch (OutOfMemoryError e) {
       assertEquals("broken!", e.getMessage());
     }

diff --git a/replaying-share/src/test/java/com/jakewharton/rx/ReplayingShareObservableTest.java b/replaying-share/src/test/java/com/jakewharton/rx/ReplayingShareObservableTest.java
@@ -28,6 +28,7 @@
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
 
 public final class ReplayingShareObservableTest {
   @Test public void noInitialValue() {
@@ -104,6 +105,7 @@ public final class ReplayingShareObservableTest {
     };
     try {
       observable.subscribe(brokenAction);
+      fail();
     } catch (OutOfMemoryError e) {
       assertEquals("broken!", e.getMessage());
     }