Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid X support #1280
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
scarrie
May 18, 2018
I got my app compiling by adding my own copies of the old package "android.support.annotation"s for @callsuper and @UiThread.
@Retention(CLASS) @Target({METHOD,CONSTRUCTOR,TYPE,PARAMETER}) public @interface UiThread { }
@Retention(CLASS) @Target({METHOD}) public @interface CallSuper { }
Its a start, but then I hit further problems caused by this new jetifier process with other libraries. Guess we just have to be patient to wait for all these third party libraries to update.
scarrie
commented
May 18, 2018
|
I got my app compiling by adding my own copies of the old package "android.support.annotation"s for @callsuper and @UiThread.
Its a start, but then I hit further problems caused by this new jetifier process with other libraries. Guess we just have to be patient to wait for all these third party libraries to update. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
allidoiswarren
commented
Jun 6, 2018
|
I'll take a crack at this. |
JakeWharton
closed this
Jun 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merged |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
justinegeo96
commented
Jun 22, 2018
|
I'm sorry to say the error still persists. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
naturalwarren
Jun 22, 2018
Contributor
Can you paste the stack trace? Are you building against a JAR cut from master?
|
Can you paste the stack trace? Are you building against a JAR cut from master? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ArunPandiyan
Jun 25, 2018
It's from the import statement for the annotations which is found in the auto generated viewbinding files.
ArunPandiyan
commented
Jun 25, 2018
|
It's from the import statement for the annotations which is found in the auto generated viewbinding files. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
k4dima
Jul 1, 2018
repositories {
maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}
implementation 'com.jakewharton:butterknife:9.0.0-SNAPSHOT'
annotationProcessor 'com.jakewharton:butterknife-compiler:9.0.0-SNAPSHOT'
k4dima
commented
Jul 1, 2018
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
danielwilson1702
Aug 28, 2018
Um, in terms of production code how safe is this on a scale of 1-10 where 1="wtf are you doing this shouldn't be in the same room as a production app"
danielwilson1702
commented
Aug 28, 2018
|
Um, in terms of production code how safe is this on a scale of 1-10 where 1="wtf are you doing this shouldn't be in the same room as a production app" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
feinstein
Aug 28, 2018
repositories {
maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}
implementation 'com.jakewharton:butterknife:9.0.0-SNAPSHOT'
annotationProcessor 'com.jakewharton:butterknife-compiler:9.0.0-SNAPSHOT'
This isn't working for me
feinstein
commented
Aug 28, 2018
This isn't working for me |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
feinstein
Aug 28, 2018
Ok, now it works, just be sure to put it inside the repositories inside allprojects and not the one inside buildscript
feinstein
commented
Aug 28, 2018
|
Ok, now it works, just be sure to put it inside the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adityathakar
commented
Sep 12, 2018
|
Is it safe to use 9.0.0-SNAPSHOT version in production code? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
SyedNabil
Sep 13, 2018
In case like me you are confused about the gradle settings, you can find the complete solution to this as a stack overflow answer: https://stackoverflow.com/a/52308912/10224384
SyedNabil
commented
Sep 13, 2018
|
In case like me you are confused about the gradle settings, you can find the complete solution to this as a stack overflow answer: https://stackoverflow.com/a/52308912/10224384 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kagile
Oct 9, 2018
Please publish releases instead of snapshots or please leave a note. Shall I update README?
kagile
commented
Oct 9, 2018
|
Please publish releases instead of snapshots or please leave a note. Shall I update README? |
xTheITx commentedMay 15, 2018
I've recently attempted to upgrade a project which uses Butterknife v8.8.1 to make use of the new Android X libraries by using the jetifier tool in Android Studio.
The project fails to compile as the generated _ViewBinding classes reference the old android.support.annotation. annotations which no longer exist.
There may also be additional issues I'm not aware of.
I was just wondering if there was a plan to migrate over to reference the new androidx package names in the generated code.
I'm not familiar with the Butterknife code, but let me know if there's anything I could contribute to the project to facilitate adding support.
Thank you for your time