Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope symbol IDs per element package name #788

Merged
merged 18 commits into from
Feb 27, 2017
Merged

Scope symbol IDs per element package name #788

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1692866
Adds failing test for #779
felipecsl Oct 20, 2016
3d83d25
Fixes #779 by scoping symbols by package
felipecsl Oct 26, 2016
e2847f1
Remove debug statements
felipecsl Oct 26, 2016
dd64ff5
Undo some changes
felipecsl Oct 26, 2016
4b8f7f5
Also revert this
felipecsl Oct 26, 2016
8098a01
Make checkstyle happy
felipecsl Oct 27, 2016
a34d982
More checkstyle
felipecsl Oct 27, 2016
34b2228
Simple rename
felipecsl Oct 27, 2016
02a845f
Merges with master
felipecsl Nov 21, 2016
25ee5d5
Merge branch 'master' into felipe/fix-779
felipecsl Feb 23, 2017
be5d12f
Generously generate QualifiedId for all package/r permutations.
BenSchwab Feb 16, 2017
4b6b08c
Final touches
felipecsl Feb 23, 2017
aa34174
Fix failing unit test
felipecsl Feb 23, 2017
4e145cd
Fix checkstyle
felipecsl Feb 24, 2017
adf5c1d
Fix bad import ordering.
JakeWharton Feb 25, 2017
67acd50
Fix more bad import ordering.
JakeWharton Feb 25, 2017
af81eff
Correct wrapping.
JakeWharton Feb 25, 2017
663d91c
Better toString and equals
JakeWharton Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ subprojects { project ->
}
}
dependencies {
classpath 'com.android.tools.build:gradle:2.2.2'
classpath 'com.android.tools.build:gradle:2.3.0-rc1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? Non-final releases are timeboxed and I don't want to commit code that uses pre-release versions because that makes the commit unbuildable after a month or two.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required. it was just Android Studio being annoying. Reverting now..

classpath 'gradle.plugin.com.kageiit:lintrules:1.1.2'
}
}
Expand Down