Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box sizing modifiers #11

Closed
JakeWharton opened this issue Nov 21, 2020 · 4 comments
Closed

Box sizing modifiers #11

JakeWharton opened this issue Nov 21, 2020 · 4 comments
Labels
enhancement New feature or request mosaic/runtime PR welcome

Comments

@JakeWharton
Copy link
Owner

The ability to specify how large a box is explicitly.

This should clip if you exceed the size. Otherwise you're padded with spaces (as is the default anyway).
@JakeWharton JakeWharton added mosaic/runtime enhancement New feature or request labels May 5, 2021
@opatry opatry mentioned this issue Jan 11, 2022
Closed
@JakeWharton
Copy link
Owner Author

Leaving this open because we can do it now, but it will likely be subsumed into #8.

@JakeWharton JakeWharton mentioned this issue Sep 6, 2022
Closed
@JakeWharton
Copy link
Owner Author

This is unblocked now.

@JakeWharton JakeWharton changed the title Box sizing Box sizing modifiers May 16, 2023
EpicDima added a commit to EpicDima/mosaic that referenced this issue May 30, 2024
@EpicDima
Some code fixes
537a69b 
- Move `Fill` and `Stroke` inside the `DrawStyle`
- Remove `toString` from `DrawStyle.Stroke` because `@Poko` is already doing it
- In the robot sample, the use of the `offset` modifier in the robot (`Text`)
- Remove `TODO JakeWharton#11 in the robot sample, it seems that it is no longer relevant
- In the robot sample, add `isActive` check in the loop for keyboard input
- Fix in the `README.md` `mutableStateOf` to `mutableIntStateOf`, as is correct in newer versions
JakeWharton pushed a commit that referenced this issue May 30, 2024
@EpicDima
Some code fixes (#384)
148502f 
- Move `Fill` and `Stroke` inside the `DrawStyle`
- Remove `toString` from `DrawStyle.Stroke` because `@Poko` is already doing it
- In the robot sample, the use of the `offset` modifier in the robot (`Text`)
- Remove `TODO #11 in the robot sample, it seems that it is no longer relevant
- In the robot sample, add `isActive` check in the loop for keyboard input
- Fix in the `README.md` `mutableStateOf` to `mutableIntStateOf`, as is correct in newer versions
@EpicDima
Copy link
Contributor

EpicDima commented Jun 8, 2024

I would like to clarify what else is currently expected within this issue?

@JakeWharton
Copy link
Owner Author

Probably nothing! Let's close. Anything else specific can get its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mosaic/runtime PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeWharton @EpicDima