Change runMosaic to support effects #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will have to look when I'm at a computer (on paternity leave until New Year). Regarding,
I think if done properly we shouldn't need a |
EpicDima
force-pushed
the
epicdima/run_mosaic_with_effects
branch
from
9a81058
to
1b6861f
Compare
EpicDima
force-pushed
the
epicdima/run_mosaic_with_effects
branch
from
1b6861f
to
22b1117
Compare
EpicDima
force-pushed
the
epicdima/run_mosaic_with_effects
branch
from
22b1117
to
b90cf3d
Compare
EpicDima
force-pushed
the
epicdima/run_mosaic_with_effects
branch
from
b90cf3d
to
a31539c
Compare
EpicDima
force-pushed
the
epicdima/run_mosaic_with_effects
branch
from
a31539c
to
c9e05b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to do #3 It works on all samples.
I haven't checked for js and native(
For jest, it seems that it would be cool to have a
MosaicScopewith a method for exiting, but it's more difficult to do it correctly