Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support synchronized update for rendering #357

Merged

Conversation

EpicDima
Copy link
Contributor

@EpicDima EpicDima commented Apr 28, 2024

I am not 100% sure of the solution, but it seems that it is possible to use this, since those who do not support the terminal feature simply will not react in any way. I'm not sure yet, because I couldn't come up with a sample case that would show the real difference, everything was always fine in both cases.

Closes #108

@EpicDima EpicDima force-pushed the epicdima/support_synchronized_update branch from f8e1f1e to 9209be2 Compare May 2, 2024 17:12
@EpicDima EpicDima force-pushed the epicdima/support_synchronized_update branch from 9209be2 to 19a80d7 Compare May 16, 2024 08:54
@EpicDima EpicDima force-pushed the epicdima/support_synchronized_update branch from 19a80d7 to 8bc6b76 Compare May 29, 2024 08:41
@EpicDima
Copy link
Contributor Author

After creating the pull request, I did an rrtop sample for a while, on it I really saw the difference when synchronized output is enabled and when it is not. So now I'm sure the code is correct 🙂

@JakeWharton JakeWharton merged commit e36abdc into JakeWharton:trunk Jun 4, 2024
1 check passed
@JakeWharton
Copy link
Owner

The reason I was hesitant was that I don't like the additional StringBuilder that this causes to be allocated. But it's fine for now, and can be improved upon later.

@EpicDima EpicDima deleted the epicdima/support_synchronized_update branch June 4, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use terminal sync for rendering
2 participants