Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate library or provide information #31

Open
PawlikMichal25 opened this issue May 7, 2018 · 4 comments
Open

Deprecate library or provide information #31

PawlikMichal25 opened this issue May 7, 2018 · 4 comments

Comments

@PawlikMichal25
Copy link

PawlikMichal25 commented May 7, 2018

Since Picasso 2.71828 has built-in OkHttp3Downloader I would suggest to deprecate this library as the built-in downloader should now be used.
Alternatively, it would be helpful to at least provide some informations about new built-in downloader in README, to help people understand why they might be facing some problems after updating their Picasso version to 2.71828 (while still using this library). This could also prevent people from opening another issues like #28, #29, #30

@JakeWharton
Copy link
Owner

JakeWharton commented May 17, 2018 via email

@zoltanf
Copy link

zoltanf commented Jun 7, 2018

Maybe just a note on the main readme that if you are using Picasso version 2.7x or newer you don't need this library but should use instead the picasso build-in downloader.
Thanks!

@dphillipsprosper
Copy link

I'd agree with @zoltanf. A quick note in the README will fix lots of confusion. I upgraded Picasso to 2.71828, but did not switch to the new version of OkHttp3Downloader, and my images stopped loading and I didn't get any real useful error messages in my logs, even after enabling logging on my Picasso instance. Switching to the new version that comes with Picasso fixed it immediately.

@LoadingIndicator
Copy link

A little note in the readme would have also saved me some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants