Changed references to SparseArray.removeAt() to SparseArray.remove() wit... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with key look up. Wrapped setAccessibilityDelegate with an SDK version check.
| @@ -98,7 +100,9 @@ void scrapActiveViews() { | |||
| } | |||
| scrapViews.put(i, victim); | |||
|
|
|||
| victim.setAccessibilityDelegate(null); | |||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) { | |||
| victim.setAccessibilityDelegate(null); | |||
|
2 spaces rather than 4, per your request. |
JakeWharton
added a commit
that referenced
this pull request
Sep 9, 2013
Changed references to SparseArray.removeAt() to SparseArray.remove() wit...
|
Awesome. Thanks! |
|
No worries. Thank you for your contributions! Eric On Mon, Sep 9, 2013 at 9:56 AM, Jake Wharton notifications@github.comwrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jake,
Great idea (this project). I made a few beneficial changes that I would like you to accept:
I believe there was a small bug in the static retrieveFromScrap function. Within the loop, where you break out early, you were removing from the scrapViews using the for loop's index. I believe you meant to remove by key here.
I have changed references to removeAt to remove() with a key look up. This makes the code compatible with versions prior to API level 11.
I wrapped the setAccessibilityDelegate in an SDK version check, making it compatible with API levels below 14.
Please accept these changes.
Eric Schlenz
P.S. I am using your ViewPagerIndicator library. Love it! Nice stuff you are contributing.