Skip to content
This repository has been archived by the owner on Apr 19, 2018. It is now read-only.

Always add Google and Android repositories #24

Merged
merged 1 commit into from
May 4, 2014
Merged

Always add Google and Android repositories #24

merged 1 commit into from
May 4, 2014

Conversation

GuillaumeDelente
Copy link
Contributor

Fix #23
With version 0.10.0 of the Android Gradle plugin, the support libraries and the Play library were always marked as outdated, triggering the downloads at each build.

Turns out the Android Gradle plugin is not including the M2 repositories anymore, and the dependencies cannot be resolved.

Previously, we were adding the repos only if they were physically missing. This PR always adds the repositories anyway (unless no dependency).

Waiting for feedback!

@JakeWharton
Copy link
Owner

Turns out the Android Gradle plugin is not including the M2 repositories anymore, and the dependencies cannot be resolved.

I don't understand how this can be the case. If you have a dependency on the support library how is it adding the dependency then?

@GuillaumeDelente
Copy link
Contributor Author

Yeah not sure what's happening.
This is what I get when I log project.repositories.maven :

9.2
file:/Users/guillaume/.android-sdk/extras/android/m2repository/

10.0
http://dl.bintray.com/populov/maven

@JakeWharton
Copy link
Owner

I'll look into the plugin.

On Fri, May 2, 2014 at 11:23 AM, gdelente notifications@github.com wrote:

Yeah not sure what's happening.
This is what I get when I log project.repositories.maven :

9.2
file:/Users/guillaume/.android-sdk/extras/android/m2repository/

10.0
http://dl.bintray.com/populov/maven


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-42062220
.

@GuillaumeDelente
Copy link
Contributor Author

The gradle plugin used to add the repos before the sdk manager plugin tries to resolve the dependencies. In 0.10.0 the repos are added after, that's why the resolution fails.

@JakeWharton
Copy link
Owner

Yes but why would this plugin need to be responsible for always adding them?

@JakeWharton
Copy link
Owner

Ah, I get it. The dependency resolution is failing due to the repository add being deferred.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Lib repo always outdated with Android Gradle Plugin to 0.10.0
2 participants