tag is null

[brescia123]

When I extend Timber.Tree and override the log method I get passed a null tag:

@Override
protected void log(int priority, String tag, String message, Throwable t) {
   if (priority == Log.VERBOSE || priority == Log.DEBUG || priority == Log.INFO) {
      return;
   }
   // tag is null
   Log.println(priority, tag, message);
}

[SimonVT]

Are you calling Timber#tag?

[brescia123]

No, why I have to call it?

[SimonVT]

Because that's what sets the tag.

[JakeWharton]

The tag is null unless you call tag(String) at the log site or extend from DebugTree (which you shouldn't do for production logging).

[brescia123]

Thank you!

[tir38]

(I'm not 100% certain what all DebugTree does so take with a grain of salt)

There is a way around this. You can use DebugTree in release builds as long as you are careful what you do inside log(...). As long as you don't call Android's Log class and you don't pass up to super you should be fine. Logs won't end up in logcat).

The use case I had was still wanting to send tag to crash reporting tool.

public class ReleaseTree extends Timber.DebugTree{

    @Override
    protected void log(int priority, String tag, String message, Throwable t){
        super.log(...); // Don't do this
        android.util.Log.xyz(...); // Don't do this

        // tag will not be null
        sentToCrashReportingTool(priority, tag, message, t);
    }
}

[jguerinet]

@JakeWharton is there any big downside in repurposing the DebugTree tag getter code for a tree used in production? Similar to what @tir38 is proposing. The goal obviously being having those tags when logging to a crash reporting library without having to define them everywhere.

Thanks

[JakeWharton]

Yes. It's extremely slow.

…

On Fri, Oct 12, 2018 at 9:23 AM Julien Guerinet ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> is there any big downside in repurposing the DebugTree tag getter code for a tree used in production? Similar to what @tir38 <https://github.com/tir38> is proposing. The goal obviously being having those tags when logging to a crash reporting library without having to define them everywhere. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#122 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEESNRdcwOvpsKB4hTzAhx6MVc64aGks5ukJe_gaJpZM4HULxq> .

[jguerinet]

Fair enough. Thanks for the quick response!