Prevent error if $modx->resource is not set #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ImagePlus snippet causes a FATAL ERROR if `$modx->resource` is not set, even if the &docid property is provided explicitly.
The snippet should only try to call `$modx->resource->get('id')` if the &docid property is NOT provided.
In normal circumstances this does not cause an issue, as `$modx->resource->get('id')` would succeed, but for example when the snippet is used from within a call to `assets/components/migx/connector.php` `$modx->resource` may be null, and in those cases `$modx->resource->get('id')` results in `Fatal error: Uncaught Error: Call to a member function get() on null` in line 27.
This is in fact a real issue when trying to use `[[ImagePlus...` in a MIGX a render chunk. For detailed analysis see here: Bruno17/MIGX#354
|
Thanks for your bug report. I have fixed this it a bit different in fff9f0b. |
|
Smooth, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImagePlus snippet causes a FATAL ERROR if
$modx->resourceis not set, even if the &docid property is provided explicitly.The snippet should only try to call
$modx->resource->get('id')if the &docid property is NOT provided.In normal circumstances this does not cause an issue, as
$modx->resource->get('id')would succeed, but for example when the snippet is used from within a call toassets/components/migx/connector.php$modx->resourcemay be null, and in those cases$modx->resource->get('id')results inFatal error: Uncaught Error: Call to a member function get() on nullin line 27.This is in fact a real issue when trying to use
[[ImagePlus...in a MIGX a render chunk. For detailed analysis see here: Bruno17/MIGX#354