Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Readme.md #67

Closed
kilmarnock opened this issue Jun 20, 2017 · 1 comment
Closed

Typo in Readme.md #67

kilmarnock opened this issue Jun 20, 2017 · 1 comment

Comments

@kilmarnock
Copy link

Hi!
Thank you for the implementation.

In the Readme.md, you say

DSO computes the camera matrix K as

K(0,0) = width * fx
K(1,1) = width * fy
K(0,2) = width * cx - 0.5
K(1,2) = width * cy - 0.5

Should be

float fx = inputCalibration[0] * in_width;
    float fy = inputCalibration[1] * in_height;
    float cx = inputCalibration[2] * in_width - 0.5;
    float cy = inputCalibration[3] * in_height - 0.5;

resp.

K(0,0) = width * fx
K(1,1) = height * fy
K(0,2) = width * cx - 0.5
K(1,2) = height * cy - 0.5

@NikolausDemmel
Copy link
Collaborator

See #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants