Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure only files are hashed #29

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Sebastian-0
Copy link
Contributor

Without this fix directories with . in the name will be matched and the script will crash when it tries to open them.

In my case we have a project where some of the sources are in the repo's root directory, and then the hashing computation matches the .git folder which is in the same folder.

Obviously this will cause problems for any folders with a dot in the name if it is within the source folder hierarchy.

Without this fix directories with . in the name will be matched and the
script will crash when it tries to open them.
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 14, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.43%.

Quality metrics Before After Change
Complexity 6.88 ⭐ 9.26 🙂 2.38 👎
Method Length 64.00 🙂 64.71 🙂 0.71 👎
Working memory 3.50 ⭐ 3.44 ⭐ -0.06 👍
Quality 68.31% 🙂 64.88% 🙂 -3.43% 👎
Other metrics Before After Change
Lines 95 96 1
Changed files Quality Before Quality After Quality Change
mkdoxy/doxyrun.py 68.31% 🙂 64.88% 🙂 -3.43% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
mkdoxy/doxyrun.py DoxygenRun.hasChanged 18 🙂 146 😞 45.77% 😞 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@JakubAndrysek JakubAndrysek merged commit 3d58b35 into JakubAndrysek:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants