Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly display inline code blocks-2 #97

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

JakubAndrysek
Copy link
Owner

Fixes the issue where inline code blocks (i.e. in a details section) don't display correctly.

This is done by first outputting all code sections as plain code blocks (using ``` without a language) and then applying a filter in the jinja2 templates that adds the active language to any plain code blocks.

fixes #79

PR by @r-braun - #96

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JakubAndrysek - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JakubAndrysek JakubAndrysek merged commit ebfa436 into main Apr 2, 2024
14 checks passed
@JakubAndrysek JakubAndrysek deleted the bugfix/issue79 branch April 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code sections don't work
2 participants