Convert to psr-4 #10
Merged
Convert to psr-4 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directories have been simplified to just src/ and test/ The Test bootstrap file is no longer needed, and the typo in the test filename has been fixed.
|
@JakubOnderka : Can you take a look at this one too? |
|
@avindra what's the purpose? it's not outlined in PR and it's not obvious why it is necessary. composer supports psr-0 now and likely indefinitely. |
|
Composer may support it indefinitely (although technically deprecation should give way to removal), but PHP devs are recommended to use PSR-4 going forward. |
|
Additionally, PSR-4 leads to better developer experience (no need to regenerate classmaps during development), and it is cleaner. Just makes sense to use it. |
|
that's what you should had put to PR description in first place! :) |
|
@JakubOnderka any chance of merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directories have been simplified to just src/ and test/
The Test bootstrap file is no longer needed, and the typo in the test
filename has been fixed.