Fix global protocol assignment special case #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special cases should be in `192.0.0.0/24`, not `192.168.0.0/24` From https://www.rfc-editor.org/rfc/rfc7723.html#section-4.1 ``` +----------------------+-------------------------------------------+ | Attribute | Value | +----------------------+-------------------------------------------+ | Address Block | 192.0.0.9/32 | | Name | Port Control Protocol Anycast | | RFC | RFC 7723 (this document) | | Allocation Date | October 2015 | | Termination Date | N/A | | Source | True | | Destination | True | | Forwardable | True | | Global | True | | Reserved-by-Protocol | False | +----------------------+-------------------------------------------+ ``` From https://www.rfc-editor.org/rfc/rfc8155.html#section-8.1 ``` +----------------------+-------------------------------------------+ | Attribute | Value | +----------------------+-------------------------------------------+ | Address Block | 192.0.0.10/32 | | Name | Traversal Using Relays around NAT Anycast | | RFC | RFC 8155 | | Allocation Date | 2017-02 | | Termination Date | N/A | | Source | True | | Destination | True | | Forwardable | True | | Global | True | | Reserved-by-Protocol | False | +----------------------+-------------------------------------------+ ```
|
Thanks, nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special cases should be in
192.0.0.0/24, not192.168.0.0/24From https://www.rfc-editor.org/rfc/rfc7723.html#section-4.1
From https://www.rfc-editor.org/rfc/rfc8155.html#section-8.1