Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image - New Component #35

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Image - New Component #35

merged 3 commits into from
Aug 27, 2020

Conversation

artemleznikov
Copy link
Member

@artemleznikov artemleznikov commented Aug 21, 2020 •
edited
Loading

#32
Simple Image Component for images which have backend processing and accept query params width and quality (Imgix, Contentful)

Features:

  • Lazy load, starts load on intersect
  • Reproduces Medium functionality, has an initial small low quality blurred fallback image, which is replaced by real image once loaded.
  • Uses srcSet and sizes to serve the best image based on width and dpi
  • Accepts 3 sizes for mobile, tablet and desktop
  • Generates a list of srcSet's based on incremental width
    image

@artemleznikov artemleznikov added the WIP Work in progress label Aug 21, 2020
@artemleznikov artemleznikov linked an issue Aug 21, 2020 that may be closed by this pull request
[Component] - Image #32
Closed
@artemleznikov artemleznikov added the new component Propose new component label Aug 21, 2020
namniak
namniak reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@namniak namniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemleznikov nice.
I see it's a WIP but leaving some early comments

src/components/Image/utils.js Outdated Show resolved Hide resolved
src/components/Image/Image.js Outdated Show resolved Hide resolved
src/components/Image/Image.scss Outdated Show resolved Hide resolved
@artemleznikov artemleznikov removed the WIP Work in progress label Aug 25, 2020
namniak
namniak approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@namniak namniak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemleznikov lgtm 👍

please rebase update the minor things in the comments below and it's ready to go!

@artemleznikov artemleznikov merged commit 22a19d5 into master Aug 27, 2020
@artemleznikov artemleznikov deleted the feature/Image branch August 27, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namniak namniak namniak approved these changes

Assignees
No one assigned
Labels
new component Propose new component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] - Image
2 participants
@artemleznikov @namniak