Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Linting + Made Hamburger Menu Optional + Improved Example and README #79

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Improved Linting + Made Hamburger Menu Optional + Improved Example and README #79

merged 8 commits into from
Jan 8, 2024

Conversation

aditya113141
Copy link
Contributor

  • Follow up to this. Made Hamburger Icon optional
  • Improved Linting
  • Updated Example with showHamburger and sideMenuExpansionItem
  • Updated README with showHamburger

@Jamalianpour
Copy link
Owner

There is not any problem with lint, thanks

But I have some issue with Expansion Item:

  • The title text was cut from the bottom
  • If I change showHamburger and use hot reload the title of the item was shown in compact mode
Screenshot 2024-01-07 at 10 08 10 PM Screenshot 2024-01-07 at 10 08 23 PM

@aditya113141
Copy link
Contributor Author

Working on it.

@aditya113141
Copy link
Contributor Author

@Jamalianpour Can you verify ?

@Jamalianpour Jamalianpour merged commit aaa322c into Jamalianpour:master Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aditya113141 @Jamalianpour