Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only notify Mergers once all requirements are satisifed #72

Open
James-Firth opened this issue Nov 1, 2019 · 0 comments
Open

Only notify Mergers once all requirements are satisifed #72

James-Firth opened this issue Nov 1, 2019 · 0 comments
Labels
Enhancement Make an existing feature better

Comments

@James-Firth
Copy link
Owner

Request from Jen via Slack:

feature request for git slackin': notify me once all the requirements are met
I often find myself forgetting about the builds I'm waiting on before merging and get side tracked

This would improve the signal-to-noise ratio for merger notifications!

  • Add a new function called checkForRequirements (or something) that will check both reviews (currently handled by checkForReviews()) and ensure the Github "Checks" are all completed/ok.
  • Perform the checkForRequirements on receipt of this webhook, to make sure notifications happens.
    https://developer.github.com/v3/activity/events/types/#checkrunevent
@James-Firth James-Firth added the Enhancement Make an existing feature better label Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Make an existing feature better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@James-Firth