Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the pdf viewer to accept some important vscode shortcuts #1406

Closed
memeplex opened this issue May 25, 2019 · 11 comments · Fixed by #1950
Closed

Allow for the pdf viewer to accept some important vscode shortcuts #1406

memeplex opened this issue May 25, 2019 · 11 comments · Fixed by #1950
Labels
feature request Feature request

Comments

@memeplex
Copy link

Is your feature request related to a problem? Please describe.

Once the pdf viewer gets focus there is too little that can be done with keys except for moving around and closing it. But, since it can be very annoying to keep the split all the time, and also to close the viewer and reopen it, retrim it, rezoom it, etc, it would be very useful to move it from and to editor groups quickly. Moreover, there is no way to drag it into its own group because it won't show the "drop zones" like standard editors do.

Describe the solution you'd like

Allow for most of vscode keys to pass through, if possible. At least Ctrl-Alt chords and Ctrl-K sequences.

Describe alternatives you've considered

Dragging and dropping with the mouse, but it's broken as described above (this happens with other previewers too, it seems more of a limitation in vscode itself).

@memeplex memeplex added the feature request Feature request label May 25, 2019
@memeplex memeplex changed the title Allow for the pdf viewer to accept some import vscode shortcuts Allow for the pdf viewer to accept some important vscode shortcuts May 25, 2019
@Mathias83
Copy link

CMD+Q on MacOS don`t closes VSCode when the Preview Tab is on fokus.
I think this could be addressed with this Issue too

@jlelong
Copy link
Collaborator

jlelong commented May 25, 2019

I have already investigated how to use VSCode's shortcuts inside the PDF Viewer but with no success. Community help is needed here. Maybe we should post on the pdf.js repo.

@jlelong jlelong added the need help Issue needs help from the community label May 25, 2019
@tamuratak
Copy link
Contributor

We can define keyboard shortcuts in viewer/latexworkshop.js if we need. By passing a message to the LaTeX Workshop process from WebView through WebSocket, we can implement a keyboard shortcut of VSCode inside the WebView.

The focus of WebView is also discussed on microsoft/vscode/issues/65413. Although fixing 65413 does not necessarily solve our problem, I want to wait for 65413 to be fixed, which is planed to done in June as the milestone tag says.

@memeplex

This comment has been minimized.

@memeplex

This comment has been minimized.

@tamuratak

This comment has been minimized.

@memeplex

This comment has been minimized.

@tamuratak

This comment has been minimized.

@memeplex

This comment has been minimized.

@tecosaur
Copy link
Contributor

@tamuratak any update on this?

@tamuratak
Copy link
Contributor

no.

tamuratak added a commit to tamuratak/LaTeX-Workshop that referenced this issue Feb 14, 2020
we have to dispatch keyboard events in the parent window.
See microsoft/vscode#65452
Close James-Yu#1406.
tamuratak added a commit to tamuratak/LaTeX-Workshop that referenced this issue Feb 15, 2020
we have to dispatch keyboard events in the parent window.
See microsoft/vscode#65452
Close James-Yu#1406.
@tamuratak tamuratak removed the need help Issue needs help from the community label Feb 15, 2020
Repository owner locked as resolved and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants