Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invert more consistent with light/dark mode #1474

Closed
memeplex opened this issue Jul 4, 2019 · 3 comments
Closed

Make invert more consistent with light/dark mode #1474

memeplex opened this issue Jul 4, 2019 · 3 comments
Labels
feature request Feature request

Comments

@memeplex
Copy link

memeplex commented Jul 4, 2019

Is your feature request related to a problem? Please describe.

I switch between dark and light modes according to ambient lighting conditions.

Accordingly, I change the pdf invert setting to adjust it to the current theme.

This is not for aesthetic reasons: with bright lights around dark mode in my glossy screen is unusable, but under better lighting conditions it's easier on my eyes.

Describe the solution you'd like

Add a new invert setting that operates only when a light theme is set. Alternatively, add a flag to disable inverting when a light theme is set.

Describe alternatives you've considered

Commenting/uncommenting the invert option in settings file. This is a cumbersome hack.

Installing an extension that sets many options at the same time. Requires an extra extension and some tweaking. It's ok but I think it's somehow wrong that, while everything else is white, the pdf previewer remains black.

@memeplex memeplex added the feature request Feature request label Jul 4, 2019
@tamuratak
Copy link
Contributor

tamuratak commented Jul 4, 2019

In an extension process, we are not able to know whether the current theme is dark or not, although there is a workaround. See microsoft/vscode/issues/32813.

@jlelong
Copy link
Collaborator

jlelong commented Jul 14, 2019

I am closing the issue for the now. Please notify us when microsoft/vscode/issues/32813 is solved and I will reopen the issue

@jlelong jlelong closed this as completed Jul 14, 2019
@tamuratak
Copy link
Contributor

#2158

Repository owner locked as resolved and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants