Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets fail in special case #857

Closed
allenryb opened this issue Oct 9, 2018 · 7 comments
Closed

Snippets fail in special case #857

allenryb opened this issue Oct 9, 2018 · 7 comments
Labels
snippets Issue is related to snippets

Comments

@allenryb
Copy link

allenryb commented Oct 9, 2018

Today I updated the new sable vscode and found that sometimes snippets fail. The code is as follows:

image

The column number after @c is 101.

But this snippet works if one of the following happens:

  1. delete one character a to make @c inside 100 columns;
  2. put @c outside A_ --- this works even beyond 100 columns.

This is related to the issue #801 .

@James-Yu
Copy link
Owner

James-Yu commented Oct 9, 2018

#58807

@James-Yu James-Yu closed this as completed Oct 9, 2018
@allenryb
Copy link
Author

allenryb commented Oct 9, 2018

#58807

Thanks for your reply!
I am sorry to make confusion.

This issue is a little different with #58807 which is influenced by 100 characters limit.
Vscode has covered this.

But my case is that snippets still fail in subscript and superscript after 100 characters.

@James-Yu
Copy link
Owner

James-Yu commented Oct 9, 2018

I don't get you. The vscode bug prevent snippets after 100 chars, which is your issue.

@allenryb
Copy link
Author

allenryb commented Oct 9, 2018

This may be a new bug.
After 100 chars, if I want to use snippet in subscript or superscript, it fail.

@jlelong
Copy link
Collaborator

jlelong commented Oct 9, 2018

There is still issue here but not related to sub or superscript.

Beyond character 100, completion is only triggered at the end of the line.
Follow #60247.

@allenryb
Copy link
Author

allenryb commented Oct 9, 2018

Thank you very much!

@jlelong
Copy link
Collaborator

jlelong commented Oct 10, 2018

Issue #60247 has been fixed in today's Insiders version and our snippets finally work great!

@jlelong jlelong added the snippets Issue is related to snippets label Oct 15, 2018
jlelong added a commit that referenced this issue Dec 12, 2018
This is a regex to determine what a word is for the LaTeX language. This
is used by vscode to trigger intellisense.
See https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributeslanguages

This finally fixes #609 #669 801 #837 #857 #883 #1059 and possible
others.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
snippets Issue is related to snippets
Projects
None yet
Development

No branches or pull requests

3 participants