Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The delay is too long. #1949

Merged
merged 2 commits into from
Feb 15, 2020
Merged

The delay is too long. #1949

merged 2 commits into from
Feb 15, 2020

Conversation

tamuratak
Copy link
Contributor

@jlelong The delay before starting builds, 2 sec, is too long. What is the purpose of this commit, aa5e6cc?

@jlelong
Copy link
Collaborator

jlelong commented Feb 15, 2020

The commit aa5e6cc was related to #1811 and #1919 (we watch PDF opened inside VSCode for automatic reload). The idea was to make sure the write process was indeed finished before triggering a fileChange event. I simply used the default value for awaitWriteFinish(see https://github.com/paulmillr/chokidar). It may not be needed for .tex files (except in #1811) but I think this is required for .pdf files which typically takes longer to be updated when they are generated by external tools. Maybe, we could change the default 2 seconds for awaitWriteFinish.stabilityThreshold. I did notice pay attention to the default 2 second delay, which is too long I agree.

@tamuratak
Copy link
Contributor Author

I am not sure the delay is really necessary. How about making it configurable?

@LPTK
Copy link

LPTK commented Mar 20, 2020

What is the status on this? Is the delay configurable?

For smaller documents, it used to be that hitting Cmd+S refreshed the PDF preview almost immediately, which was great.

Now, whenever I need to make a tikz figure for instance, where I need quick feedback to see what my changes look like, I have to wait for this huge delay, which quite literally ruins my productivity doing this sort of tasks.

@tamuratak
Copy link
Contributor Author

tamuratak commented Mar 20, 2020

It will be available in the next release. Use the previous version until it. See https://github.com/James-Yu/LaTeX-Workshop/wiki/FAQ#install-older-version.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants