-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live share integration #4308
base: master
Are you sure you want to change the base?
Live share integration #4308
Conversation
Awesome! Great contribution @quoc-ho . Let's wait for review. |
The following functionalities have been implemented on guests (on the host, everything is the same as before):
Here, * means doesn't work when the guest is on a Windows computer. This is because on Windows, Build command cannot be triggered from the guest yet (but it's not hard to implement). For now, the host can just turn on build on save. Notes on the implementation
|
I'm back. On it in the next week(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check carefully (next step will do so), yet it seems that currently synctex from guest to host then back to guest is adding a lot of lines to the code, which is making the code quite convoluted.
I would recommend removing all host-guest communications related to synctex. For guest, rely on its local optionally-installed synctex
and fallback to the bundled synctexjs
implementation. This will make the code much more maintainable.
Thanks for looking into this. I think the changes are quite minimal. The large changes in I'm traveling for quite a while so I will be available only for comments if you have questions but probably not actually writing code. |
I've done some refactoring to follow minimal intrusion. May you have a check if the new code is equivalent when available? Further, as there are some limited functionalities on Windows, it would be good to have sort of notices when related functions are invoked on win. |
Great! I'll go over the refactor by Tuesday. |
Continue the discussion #4305 (reply in thread).