Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore " in Latex syntax highlighting. #604

Merged
merged 2 commits into from
May 7, 2018
Merged

Conversation

jlelong
Copy link
Collaborator

@jlelong jlelong commented May 6, 2018

Along with 1dcb0d7, it closes #593.

@@ -1673,7 +1642,7 @@ Put specific matches for particular LaTeX keyword.functions before the last two
</dict>
</dict>
<key>end</key>
<string>''|"</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While using " to close `` is informal (and maybe incorrect), I've personally met with a lot of people who would do so. Is it possible to retain the closing " here?

@jlelong
Copy link
Collaborator Author

jlelong commented May 7, 2018

I have just reverted part of the commit to allow " to close ``.

@James-Yu James-Yu merged commit 4b6acb5 into James-Yu:master May 7, 2018
@jlelong jlelong deleted the quotes branch May 7, 2018 07:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlight for quotation marks
2 participants