-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #154 -- adds isort #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool addition 👍
And a quick question.
knox/auth.py
Outdated
from knox.crypto import hash_token | ||
from knox.models import AuthToken | ||
from knox.settings import CONSTANTS, knox_settings | ||
from knox.signals import token_expired | ||
from rest_framework import exceptions | ||
from rest_framework.authentication import (BaseAuthentication, | ||
get_authorization_header) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we configure isort so that it gives:
from rest_framework.authentication import (
BaseAuthentication,
get_authorization_header,
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnraz
Yes my friend, consider it done :)
However, do you want it exactly like you said or if you check here "5 - Hanging Grid Grouped" or "4 - Hanging Grid"? Currently the project is configure with number 5 option. Please let me know what you prefer, I think 5 is a bit more effective use of space though.
awesome, 2 quick remarks:
|
@belugame we can configure |
yes, great :) 👍 |
fixes jazzband#154 -- adds isort
Hello,
Adds isort to testenv and sorts all imports. Closes #154 🐈
We might want to add some extra rules, personally I run these in my projects:
Also, this does not test the imports in
tests/
. Let me know if that feels like something you might want.Cheers mates