Skip to content

Commit

Permalink
demos missing from master.zip
Browse files Browse the repository at this point in the history
  • Loading branch information
@JamesHeinrich
JamesHeinrich committed Dec 30, 2019
1 parent 917641b commit a24656a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .gitattributes
View file
Expand Up @@ -28,7 +28,6 @@
.travis.yml export-ignore
build/ export-ignore
composer.json export-ignore
demos/ export-ignore
Doxyfile export-ignore
phpstan.neon export-ignore
phpunit.xml.dist export-ignore
Expand Down

3 comments on commit a24656a

@reedy
Copy link
Contributor

@reedy reedy commented on a24656a Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this then means that installing the library via composer now have them...

@JamesHeinrich
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that cause problems?

@reedy
Copy link
Contributor

@reedy reedy commented on a24656a Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not major ones, but it's a few hundred KB of extra stuff that most people installing via composer don't need/want. And when you're deploying that to hundreds of servers...

Obviously the side effect here is that .gitattributes affects the zip downloads, which is to be expected.

Though, how many people are really using those day to day? I'd presume most people git clone or composer...

Please sign in to comment.