Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error in RIFF parser #105

Closed
andrejasimovic opened this issue Mar 26, 2017 · 4 comments
Closed

Fatal error in RIFF parser #105

andrejasimovic opened this issue Mar 26, 2017 · 4 comments

Comments

@andrejasimovic
Copy link

andrejasimovic commented Mar 26, 2017 •
edited
Loading

Hi,
I am experiencing fatal error with the RIFF parser:
PHP Fatal error: Unsupported operand types in project/vendor/james-heinrich/getid3/getid3/module.audio-video.riff.php on line 431

It happens with the file which BWFXML contains two TIMESTAMP_SAMPLE_RATE tags, and resulting array has TIMESTAMP_SAMPLE_RATE in a form of array [48000,48000], instead of int/double, which causes described fatal error.

I have attached xml file. BWFXML.txt

Please let me know if I can help more with this issue.
JamesHeinrich added a commit that referenced this issue Mar 26, 2017
@JamesHeinrich
RIFF.WAVE.iXML multiple TIMESTAMP_SAMPLE_RATE
618baab 
fatal error if XML contains two TIMESTAMP_SAMPLE_RATE tags
#105
@JamesHeinrich
Copy link
Owner

Please try fix in 618baab
Let me know if that does not solve the problem.

I'm still not sure why the XML would contain more than one TIMESTAMP_SAMPLE_RATE tag, but since that's apparently possible I guess getID3 should handle that possibility.

@andrejasimovic
Copy link
Author

andrejasimovic commented Mar 27, 2017 •
edited
Loading

Hi @JamesHeinrich
Fix you provided solved the problem.
Thanks a lot!

@JamesHeinrich
Copy link
Owner

https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.14

@andrejasimovic
Copy link
Author

Thanks a lot!
You rock! 👍 :)

StudioMaX pushed a commit to StudioMaX/getID3 that referenced this issue May 26, 2019
@JamesHeinrich @StudioMaX
RIFF.WAVE.iXML multiple TIMESTAMP_SAMPLE_RATE
f7bde8c 
fatal error if XML contains two TIMESTAMP_SAMPLE_RATE tags
JamesHeinrich#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHeinrich @andrejasimovic