Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getID3 converts songfile embedded picture to HTML #178

Closed
Nizhile opened this issue Feb 5, 2019 · 1 comment
Closed

getID3 converts songfile embedded picture to HTML #178

Nizhile opened this issue Feb 5, 2019 · 1 comment

Comments

@Nizhile
Copy link

Nizhile commented Feb 5, 2019

Working on a performance problem at Sonerezh/sonerezh#354, I noticed that getID3 makes some effort to convert the full comments['picture'] to HTML. Then the converted string is removed from the infos['comment_html'].
I guess applications usually set option_tags_html to false (default is true). Anyway, this seems to be a bug in getID3.HandleAllTags().
JamesHeinrich added a commit that referenced this issue Feb 7, 2019
@JamesHeinrich
HandleAllTags should skip "picture"
81ab4c6 
#178
@JamesHeinrich
Copy link
Owner

Thanks, fixed in #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHeinrich @Nizhile