Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Reduce information for GIF files with $option_extra_info #183

Closed
RobertLang opened this issue May 3, 2019 · 1 comment
Closed

Comments

@RobertLang
Copy link

Hi,
when using getID3 to store meta information on different file formats I noticed that the information returned for GIF files is way too large and it takes quite some time.

Wouldn't it make sense to use the $option_extra_info (or another option) to skip information on global_color_table and extension_blocks to make processing more efficient?

Thanks for considering.

JamesHeinrich added a commit that referenced this issue May 11, 2019
#183
If getid3->option_extra_info == false, do not parse or return
global_color_table, do not return extension_blocks
@JamesHeinrich
Copy link
Owner

The global_color_table still needs to be read/skipped (although parsing it into actual table values is not required). extension_blocks need to be parsed to check whether the GIF is animated or not.
However I can make it not return that data if option_extra_info is false. You might save a millisecond or two by not expanding the global color table, but it's not a whole lot faster.
Changed in fe4e0a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants