Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple id3v2 artists are not copied when using CopyTagsToComments() #206

Closed
blakyris opened this issue Nov 26, 2019 · 4 comments
Closed

Multiple id3v2 artists are not copied when using CopyTagsToComments() #206

blakyris opened this issue Nov 26, 2019 · 4 comments

Comments

@blakyris
Copy link

Most of the time for me files read by getID3() shows multiple artists in an array when they are stored in a ID3v2 format but just the first artist is copied when using CopyTagsToComments() so I have to extract my self which is VERY anoying because I have to handle all tags format myself.
@JamesHeinrich
Copy link
Owner

Can you please provide a sample file with multiple artists to ease my testing?

@blakyris
Copy link
Author

Yes sure !
The file was encoded from FLAC to MP3 using MusicBee. In the FLAC format tags are correctly read.

console-tags
windows-tags
track.zip

JamesHeinrich added a commit that referenced this issue Nov 26, 2019
@JamesHeinrich
bugfix #206 - inverted logic in CopyTagsToComments
96430a1 
#206
tags with multiple entries in any category (e.g. artist) would overwrite
instead of append
@JamesHeinrich
Copy link
Owner

One missing character inverted the logic. Thanks for the sample file, it made testing and fixing easy.
Fixed in 96430a1

@blakyris
Copy link
Author

Thanks !!! That will make my life easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHeinrich @blakyris