You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My test suite is throwing a fit at the presence of these lines from the main getid3 class, as simply retrieving the setting at all in the newly-released PHP 7.4 triggers a deprecation warning that it's no longer supported at all.
I'm not sure what the project would prefer as far as a solution to this, either removing the lines altogether or wrapping them in a PHP version check, but it would be good to avoid them being executed at all in 7.4 and beyond, even if the function names themselves exist.
The text was updated successfully, but these errors were encountered:
I also noticed there was an error in the second function, checking for the existence of magic_quotes_gpc and then running get_magic_quotes_gpc, that's now fixed too. That may have been the cause of your test suite "throwing a fit".
Hello all!
My test suite is throwing a fit at the presence of these lines from the main
getid3
class, as simply retrieving the setting at all in the newly-released PHP 7.4 triggers a deprecation warning that it's no longer supported at all.I'm not sure what the project would prefer as far as a solution to this, either removing the lines altogether or wrapping them in a PHP version check, but it would be good to avoid them being executed at all in 7.4 and beyond, even if the function names themselves exist.
The text was updated successfully, but these errors were encountered: