Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 Deprecated magic_quotes functions #210

Closed
BusterNeece opened this issue Nov 30, 2019 · 1 comment
Closed

PHP 7.4 Deprecated magic_quotes functions #210

BusterNeece opened this issue Nov 30, 2019 · 1 comment

Comments

@BusterNeece
Copy link

Hello all!

My test suite is throwing a fit at the presence of these lines from the main getid3 class, as simply retrieving the setting at all in the newly-released PHP 7.4 triggers a deprecation warning that it's no longer supported at all.

I'm not sure what the project would prefer as far as a solution to this, either removing the lines altogether or wrapping them in a PHP version check, but it would be good to avoid them being executed at all in 7.4 and beyond, even if the function names themselves exist.

@JamesHeinrich
Copy link
Owner

Thanks, fixed in 75454e8

I also noticed there was an error in the second function, checking for the existence of magic_quotes_gpc and then running get_magic_quotes_gpc, that's now fixed too. That may have been the cause of your test suite "throwing a fit".

JamesHeinrich added a commit that referenced this issue Dec 27, 2019
Similar to #210 fixes for
demo.browse for PHP v7.4 deprecation warnings for
get_magic_quotes_runtime / get_magic_quotes_gpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants